Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @kshitij-microsoft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for a default_deployment_template parameter to the model creation functionality in Azure Machine Learning Services CLI extension. This integration enables users to specify a default deployment template when creating models.
Key Changes
- Added
default_deployment_templateparameter toml_model_createfunction signature - Updated
Modelconstructor call to pass the new parameter - Added CLI argument definition for
--default-deployment-templateoption
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/machinelearningservices/azext_mlv2/manual/custom/model.py | Added default_deployment_template parameter to function signature and Model constructor; contains misplaced argument definition code |
| src/machinelearningservices/azext_mlv2/manual/_params/_model_params.py | Added proper CLI argument definition for --default-deployment-template in the parameter loading function |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please fix CI issues |
kshitij-microsoft
force-pushed
the
DT-integration
branch
from
38caa1b to
af52a23
Compare
Release SuggestionsModule: machinelearningservices
Notes
|
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
src/machinelearningservices/azext_mlv2/manual/_params/_model_params.py
Outdated
Show resolved
Hide resolved
kshitij-microsoft
requested review from
feiskyer,
howang-ms,
mainred and
nilo19
as code owners
kshitij-microsoft
requested review from
FumingZhang,
Greedygre,
Juliehzl,
andyliuliming,
evelyn-ys,
jiasli,
wangzelin007 and
zhoxing-ms
as code owners
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.